feat(dashboard): daily cost line + This Month timezone fix#151
Open
paulabenzar wants to merge 2 commits into
Open
feat(dashboard): daily cost line + This Month timezone fix#151paulabenzar wants to merge 2 commits into
paulabenzar wants to merge 2 commits into
Conversation
Adds a per-day cost line (accent color, right y2 axis) on top of the existing stacked bar chart. Cost is accumulated per model during the daily aggregation pass so per-model pricing is applied correctly, then rendered as a Chart.js line dataset with a dedicated y-axis.
…UTC shift toISOString() outputs UTC, so in UTC+ timezones midnight local time converts to the previous UTC date — causing "This Month" to include the last day of the previous month. Use getFullYear/getMonth/getDate (local) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linedataset on a dedicated right-side y-axis (accent color), computed per model before the daily aggregation so per-model pricing is applied correctly. Toggleable via the legend like all other series.getRangeBoundswas usingtoISOString()(UTC) to format dates constructed from local midnight, which shifted one day back. Now usesgetFullYear/getMonth/getDate(local) throughout.Test plan
$values on the right axispython3 -m unittest discover -s tests -v)